Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: cleanup autogen #730

Merged
merged 6 commits into from May 28, 2020
Merged

docs: cleanup autogen #730

merged 6 commits into from May 28, 2020

Conversation

williaster
Copy link
Collaborator

@williaster williaster commented May 27, 2020 •
edited

馃彔 Internal

This PR cleans up a bit from #681 (react-docgen-typescript-loader) and closes #680, it:

  • removes the legacy static doc scripts
  • removes react-docgen dep from the monorepo root as this is now in vx-demo
  • refactors the __docgenInfo extraction from individual /pages/doc pages to the DocPage component itself to simplify doc page creation and push all of the needed @ts-ignores to one place
  • fixes a broken .html link I missed

Testing

  • CI
  • Checked each doc page to make sure it rendered after the __docgenInfo refactor

@hshoff @kristw

@williaster williaster added this to the v1 milestone May 27, 2020
@williaster williaster requested a review from hshoff May 27, 2020 22:42
@williaster williaster merged commit 3d42c2f into master May 28, 2020
@williaster williaster deleted the chris--docgenInfo-cleanup branch May 28, 2020 21:49
@hshoff hshoff modified the milestones: v1, v0.0.197 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

Assignees
No one assigned
Labels
馃彔 internal
Projects
No open projects
V1
Awaiting triage
Milestone
v0.0.197
Development

Successfully merging this pull request may close these issues.

docs: fix doc-gen
2 participants
@williaster @hshoff