New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link render bugs #68

Open
potash opened this Issue Mar 15, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@potash

potash commented Mar 15, 2014

URLs are not hidden when they do not immediately follow an *. E.g.

*[[url]][[description]]

works but

* [[url]][[description]]

does not. Neither does

* click [[url]][[here]]

Also links with multiline urls are not concealed properly. Instead of being removed, it is replaced with whitespace and the description follows.

@hsitz

This comment has been minimized.

Show comment
Hide comment
@hsitz

hsitz Mar 15, 2014

Owner

On Fri, Mar 14, 2014 at 9:59 PM, potash notifications@github.com wrote:

URLs are not hidden when they do not immediately follow an *. E.g.

*[[url]][[description]]

works but

  • [[url]][[description]]

also when
does not. neither does

  • click [[url]][[here]]

I haven't looked at this stuff for a long time. Not sure whether I made
conscious decision not to have links in headlines b/c too hard to
implement, or whether I just forgot. Seems to me now like it would be
simple change to syntax specs but I'm not sure.

Also links with multiline urls are not concealed properly. Instead of
being removed, it is replaced with whitespace and the description follows.

Almost certain this is because conceal in Vim works only on single lines.
Doing something to enable on multiple lines would be more complicated
kludge, involving multiple concealed regions. I'm not sure what your
"multiline" url is. If you avoid wrapping then can't all url's be single
line url's? That is, cr/lf is not part of properly constructed url?

-- Herb

Owner

hsitz commented Mar 15, 2014

On Fri, Mar 14, 2014 at 9:59 PM, potash notifications@github.com wrote:

URLs are not hidden when they do not immediately follow an *. E.g.

*[[url]][[description]]

works but

  • [[url]][[description]]

also when
does not. neither does

  • click [[url]][[here]]

I haven't looked at this stuff for a long time. Not sure whether I made
conscious decision not to have links in headlines b/c too hard to
implement, or whether I just forgot. Seems to me now like it would be
simple change to syntax specs but I'm not sure.

Also links with multiline urls are not concealed properly. Instead of
being removed, it is replaced with whitespace and the description follows.

Almost certain this is because conceal in Vim works only on single lines.
Doing something to enable on multiple lines would be more complicated
kludge, involving multiple concealed regions. I'm not sure what your
"multiline" url is. If you avoid wrapping then can't all url's be single
line url's? That is, cr/lf is not part of properly constructed url?

-- Herb

@potash

This comment has been minimized.

Show comment
Hide comment
@potash

potash Mar 15, 2014

Ah, okay they work outside the headings. And I had enabled wrap (for formatting long item bodies) but disabling it makes long urls work fine. Thanks!

potash commented Mar 15, 2014

Ah, okay they work outside the headings. And I had enabled wrap (for formatting long item bodies) but disabling it makes long urls work fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment