New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force exclusion of all subfolders when excluding a folder #248

Closed
hsoft opened this Issue Jan 4, 2014 · 1 comment

Comments

1 participant
@hsoft
Owner

hsoft commented Jan 4, 2014

In the folder selection dialog, it's possible to end up with confusing scan preferences when playing with folder states. When setting the state of a folder, it applies for all subfolder, except those with an explicitly specified state. This logic can lead to a user thinking that he excluded a whole folder when it's in fact not the case. Example:

  1. Set a folder /foo/bar as "Reference".
  2. Do something else, perform some scanning, and forget about /foo/bar.
  3. Later, set /foo as excluded.

foo/bar will keep its former "Reference" state, possibly without the knowledge of the user.

Given the high likeliness that a user setting a root folder's state as "Excluded" means to exclude everything underneath, without exception, I think it's better to override all previous states for subfolders. The user can always re-specify a subfolder state afterwards.

@hsoft

This comment has been minimized.

Owner

hsoft commented Mar 15, 2014

I'll extend this behavior to all folder states. I think that's what most users would expect.

@hsoft hsoft self-assigned this Mar 15, 2014

@hsoft hsoft closed this in 781f13a Apr 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment