New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when closing without saving (opted out) #379

Open
GM-Script-Writer-62850 opened this Issue Jul 19, 2016 · 2 comments

Comments

2 participants
@GM-Script-Writer-62850

GM-Script-Writer-62850 commented Jul 19, 2016

Installed from the ppa here; on 14.04
https://launchpad.net/~hsoft/+archive/ubuntu/ppa/

Application Name: dupeGuru
Version: 4.0.0

Traceback (most recent call last):
  File "/usr/share/dupeguru/qt/result_window.py", line 321, in appWillSavePrefs
    prefs = self.app.prefs
AttributeError: 'NoneType' object has no attribute 'app'
Application Name: dupeGuru
Version: 4.0.0

Traceback (most recent call last):
  File "/usr/share/dupeguru/qt/details_dialog.py", line 40, in appWillSavePrefs
    if self._shown_once:
AttributeError: 'NoneType' object has no attribute '_shown_once'

Thanks for making this application, so much easier to remove those duplicates from my collection of saved images, just got rid of 110 duplicates (5.5% of my collection)
I was using scripts i wrote that compared meta data, which worked very nicely untiled i needed to compare alt dimensions

@hsoft hsoft added the bug label Jul 20, 2016

hsoft added a commit that referenced this issue Aug 15, 2016

qt: save prefs on close more predictably
Ticket #379 reports crashes on quit due to `willSavePrefs` being called
when result and details dialogs are already freed. I can't reproduce the
crash, but it's still a bad idea to rely on the timing of
`aboutToQuit()` to launch this process.

This commits uses a more predictable place to emit `willSavePrefs` and
I'm pretty sure it will fix the crash at #379.
@hsoft

This comment has been minimized.

Owner

hsoft commented Aug 15, 2016

Thanks for the report @GM-Script-Writer-62850 . I can't reproduce the crash though (even on my 14.04 environment). Does it happen every time you quit dupeGuru?

In the commit referenced above, I make a change that I think would fix the crash. Are you technical enough to build dupeGuru from source? If yes, and if you can reproduce the crash reliably, could you please try to build from master and let me know if the crash is fixed?

@GM-Script-Writer-62850

This comment has been minimized.

GM-Script-Writer-62850 commented Aug 15, 2016

depends on how detailed the instructions are
need to make sure i can reproduce it still to verify (seems to work fine ATM), maybe i need to delete the programs configuration data
/home/$USER/.local/share/Hardcoded Software
/home/$USER/.config/Hardcoded Software

this issue came up when i first used the software
** try deleting /home/$USER/.config/Hardcoded Software
scan for pictures and try to exit and click yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment