dupeGuru 4.0.1 #394

pnn314 opened this Issue Sep 22, 2016 · 14 comments


None yet

6 participants

pnn314 commented Sep 22, 2016

dupeGuru 4.0.1 does not work on macOS Sierra with pictures. It freezes.

greck commented Sep 23, 2016

I've had crashes on two different Sierra-running systems today; here are some details from one of them.


  • iMac (21.5-inch, Mid 2010)
  • macOS Sierra 10.12
  • dupeGuru 4.0.1


  • Uninstall app, delete preferences
  • Install 4.0.1, change no defaults
  • Chose a directory to scan, use normal mode
  • Select Picture, and Contents, and start scan
  • During scanning, at "Performed 0/n chunk matches" an exception will occur


Crash report and screenshot attached.

dupeguru_4 0 1_on_sierra_crash

@hsoft hsoft added the bug label Sep 29, 2016
@hsoft hsoft self-assigned this Sep 29, 2016
hsoft commented Sep 29, 2016

Sorry for the delay, I lack availability these days. It sounds like a bad problem, I'll look into it soon.

greck commented Sep 29, 2016

I feel the lack of availability; I'm about to go on vacation (finally) and hope to have free time when I get back, and will take a look myself if it's unresolved.

hsoft commented Sep 30, 2016 edited

It looks like a tricky problems. The crash stack trace looks a lot like https://bugs.python.org/issue27126 , which has no resolution.

What I find strange is that the bug does not seem sierra-specific. Maybe that apple-suplied sqlite always caused random crashes, but that with sierra, they became systematic. I don't know.

A possible solution seems to be to ship with a private version of sqlite instead of linking to apple's. Another solution would be to implement an alternative implementation of core.pe.cache.Cache with a shelve backend.

hsoft commented Oct 1, 2016

I've made early tests with a the pre-compiled Python 3.5.2 that comes from python.org (the bug linked in my previous comment mentions that it's built with a private version of sqlite) and it fixes the crash. Previous dupeGuru builds are made with a locally compiled Python, and this one links to the system-provided sqlite.

This is, however, not an elegant solution. To have dupeGuru build properly, I had to fudge around with the python package to remove i386 from sysconfig. Otherwise, I would get link errors.

That is, however, more fitting of a bugfix release than a completely new implementation of the picture cache.

So the plan would be to release a dupeGuru 4.0.2 with a fudged-around pre-compiled python and a dupeGuru 4.1 with a shelve-based picture cache. If that implementation is significantly slower than the sqlite version, it could be conditionally loaded (sqlite would be enabled on linux only).

hsoft commented Oct 6, 2016

I've created a test build and uploaded it at https://download.hardcoded.net/dupeguru_osx_4_0_1_sierra_test.dmg (pgp signature at https://download.hardcoded.net/dupeguru_osx_4_0_1_sierra_test.dmg.sig).

On my machine it fixed the crash. Can anyone confirm on their machine?

pnn314 commented Oct 6, 2016

Can not download:
403 Forbidden

hsoft commented Oct 6, 2016

@pnn314 oops, sorry. It's fixed now.

pnn314 commented Oct 6, 2016

Now it works OK on my iMac without freezing and crash.

6 окт. 2016 г., в 4:30, Virgil Dupras notifications@github.com написал(а):

@pnn314 https://github.com/pnn314 oops, sorry. It's fixed now.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #394 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AVUz7MBz8GsTNW9egQl3lxaq3FkPQMZiks5qxE8cgaJpZM4KDfHB.

what2be commented Oct 6, 2016

Works for me now as well. Thank you!!!

Vinfab commented Oct 7, 2016

Its works now. No more crashes! Many thanks, JP

• iMac (27-inch, Late 2014)
• macOS Sierra 10.12.1
• dupeGuru 4.0.1 Sierra test

hsoft commented Oct 7, 2016

Good, thanks for testing everyone. I'll release v4.0.2 soon.


Looks like I'm a bit late, but this fix also worked for me.

iMac 27 - Late 2013
3.2 GHz Intel Core i5
Mac OS 10.12 (16A323)

Thanks a bunch

hsoft commented Oct 11, 2016

Fixed in v4.0.2.

@hsoft hsoft closed this Oct 11, 2016
@hsoft hsoft added a commit that referenced this issue Nov 16, 2016
@hsoft Add shelve-based picture cache implementation
Hopefully, this will fix #394 for real this time, that is, without the
need for a messy python executable ship in the app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment