New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash during CSV import #128

Closed
hsoft opened this Issue Jun 22, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@hsoft
Owner

hsoft commented Jun 22, 2013

@@@
Application Identifier: com.hardcoded_software.moneyguru
Application Version: 1.7.4

Traceback (most recent call last):
File "/Applications/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 1365, in continueImport
File "core/gui/csv_options.pyc", line 136, in continue_import
File "core/document.pyc", line 988, in load_parsed_file_for_import
File "core/loader/base.pyc", line 205, in load
File "core/loader/csv.pyc", line 87, in _load
File "core/loader/base.pyc", line 84, in clean_date
TypeError: expected string or buffer
@@@

The user sent me the file that caused the error and I could reproduce the bug. Pressing Continue Import once pops up a message telling that the date column doesn't contain dates, but after that, all values in the column would become empty. Pressing Continue Import again would trigger this error.

@hsoft hsoft closed this Jun 22, 2013

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

This bug is two-fold. The first problem is that moneyGuru can't recognize the date. But the underlying problem is that moneyGuru changes the vales of the CSV lines when it parses the dates. Cells with invalid dates are set to None, which makes the whole file un-importable after having tried to continue import with a wrong date column.

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

(from [2025e4148457]) [#128] Trying to load a CSV file no longer modifies raw lines.
http://bitbucket.org/hsoft/moneyguru/changeset/2025e4148457/

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

(from [156ea7f35ab9]) [#128 state:fixed] CSV imports now support dates with very short formats.
http://bitbucket.org/hsoft/moneyguru/changeset/156ea7f35ab9/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment