Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten up de-reconciliation upon transaction editing #237

Closed
hsoft opened this issue Jun 22, 2013 · 3 comments
Closed

Tighten up de-reconciliation upon transaction editing #237

hsoft opened this issue Jun 22, 2013 · 3 comments
Labels

Comments

@hsoft
Copy link
Owner

@hsoft hsoft commented Jun 22, 2013

Currently, moneyGuru "over de-reconcile" when editing transactions. For example, when a reconciled transaction moves money from an asset to an expense account, changing the "To" column of that transaction will de-reconcile the asset entry, even though no actual change is made to that entry.

For people not using the "Reconciliation date" feature, it's not a big deal. Just press the spacebar, and the entry is reconciled again. However, for people having set a reconciliation date that is different from the entry date, important data is lost in this de-reconciliation and it's annoying to have to re-enter it.

@hsoft hsoft closed this Jun 22, 2013
@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 22, 2013

Although the behavior of the transaction table w.r.t de-reconciliation is not a bug itself, the reason why there's this behavior is kind of buggish in nature (it's an unintended byproduct of currency setting in Transaction.change()), so I'm fixing this for 2.3.6

@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 22, 2013

Or is it...? Bah, I'll get to the bottom of this.

@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 22, 2013

(from [b81fda8fa527]) [#237 state:fixed] Fixed erronous de-reconciliation on ttable edits.
https://bitbucket.org/hsoft/moneyguru/changeset/b81fda8fa527/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant