Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number format with spaces cause troubles at parsing time #316

Closed
hsoft opened this issue Jun 22, 2013 · 4 comments
Closed

Number format with spaces cause troubles at parsing time #316

hsoft opened this issue Jun 22, 2013 · 4 comments
Labels

Comments

@hsoft
Copy link
Owner

@hsoft hsoft commented Jun 22, 2013

From GS

My number format contains spaces, so when I modify a number in moneyGuru I have to delete the space first, otherwise the old number comes back after hiting Enter. That would be great to take spaces into account during entry validation.

@hsoft hsoft closed this Jun 22, 2013
@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 22, 2013

I could reproduce that bug. With spaces as thousand separators, parsing fails.

@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 22, 2013

Oh well, it turns out that after more testing, space separator work fine, as long as there's only one of them. For example, "1 234" would work fine, but not "1 234 567". The thing is that the bug affects all space separators.

@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 22, 2013

Oh, no, I was all wrong. it's really the spaces that are the problem. It's just that sometimes, we get a xa0 character which is a non-breaking space. We just have to support those.

@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 22, 2013

(from [073178b99bd6]) [#316 state:fixed] Fixed bug where parsing would fail with non-breaking space in the string.
https://bitbucket.org/hsoft/moneyguru/changeset/073178b99bd6/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant