New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow space separator in date parsing in import #324

Closed
hsoft opened this Issue Jun 22, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@hsoft
Owner

hsoft commented Jun 22, 2013

One of my banks produces CSV files with dates in the following format: "04 APR 2012"
moneyGuru does not like this because the separator is a space, rather than a hyphen '-' or forwardslash '/' character.

If it doesn't break any other functionality of the CSV parsing, it'd be useful for me if moneyGuru could allow space separators for dates

(to be honest it's only an issue for me because of the other bug I reported in QIF importing, but seems general enough to me that it might be useful to others too)

@hsoft hsoft closed this Jun 22, 2013

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

If it exists somewhere, it's worth supporting.

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

(from [26431e6aad84]) [#324 state:fixed] Added spaces as a possible date element separator in date format guessing routine.
https://bitbucket.org/hsoft/moneyguru/changeset/26431e6aad84/

@hsoft

This comment has been minimized.

Owner

hsoft commented Jun 22, 2013

(from [4d76edec957f]) [#324] Fixed the bogus commit previously fixing this ticket.

First, I hadn't noticed that there was already a higher-level, more proper place for date format guessing tests in import_test, so I didn't put the test in the right place. Moreover, the test being more high level revealed that I didn't adjust the regexp for possibly correct dates, which I do in this commit.
https://bitbucket.org/hsoft/moneyguru/changeset/4d76edec957f/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment