Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed currency fetching are retried repeatedly #374

hsoft opened this issue Sep 21, 2013 · 0 comments

Failed currency fetching are retried repeatedly #374

hsoft opened this issue Sep 21, 2013 · 0 comments


Copy link

@hsoft hsoft commented Sep 21, 2013

When a currency rate can't be fetched because the currency server doesn't have it (for example, if it's for a date prior to the server's first data on that currency, example: ILS on 2011-01-01), moneyGuru will repeatedly try to fetch it, forever.

moneyGuru should correctly mark the currency as fetched with the nearest rate as a value.

Warning: it's important to differentiate error responses from empty responses, otherwise we might end with with a cache falsely having empty rates forever because the connection to the currency server was temporarily buggy.

@hsoft hsoft closed this in f69cf09 Sep 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant