New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right arrow account decorations only work for selected items #404

Closed
brownnrl opened this Issue Dec 11, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@brownnrl
Contributor

brownnrl commented Dec 11, 2014

While fixing the other issue with amount painting, I noticed in the transactions table you can only click on the right arrow decorations on the first item of the current selection. Actually clicking the other arrows will still bring you to the account of the first selected item. I thought I might have introduced another bug, but I see it was like that before. I was briefly looking at ways to change it, but I thought maybe this was purposeful. Is this intended behavior?

@hsoft

This comment has been minimized.

Owner

hsoft commented Dec 11, 2014

I noticed it too. I think it's a rather newly introduced bug, otherwise I think I would have noticed it before now.

Of course, the expected behavior is to "action" the row in which the button is, not the selected rows.

It happens in balance sheet and profit & loss too (which makes me think that you aren't the culprit this time :) ).

@hsoft

This comment has been minimized.

Owner

hsoft commented Dec 13, 2014

Oh well, it's a regression: it doesn't happen in 2.7.2 (selection changes right before the decoration click is registered)

@hsoft

This comment has been minimized.

Owner

hsoft commented Dec 13, 2014

My guess is that 56678e1 is the one.

@hsoft hsoft closed this in 854ff06 Dec 13, 2014

@hsoft

This comment has been minimized.

Owner

hsoft commented Dec 13, 2014

It's a big commit for a fix, but decoration click handling is now much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment