Skip to content

/ moneyguru

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Will import column brings up no-operation editor (Qt) #406

Closed
brownnrl opened this issue Dec 17, 2014 · 3 comments
Closed

Will import column brings up no-operation editor (Qt) #406

brownnrl opened this issue Dec 17, 2014 · 3 comments
Labels
bug

Comments

@brownnrl
Copy link
Contributor

@brownnrl brownnrl commented Dec 17, 2014

Minor ticket, this should be resolved as part of #26. During work on that ticket I noticed that pressing the return key while highlighting a row in the import window (not csv_options, the window thereafter) will bring up a text-based editor for the 'will_import' column. This is due to that column being editable, but having no editor defined for it (since it's just a checkbox).

I've fixed the issue in my working copy, but in the event a PR isn't approved for #26 (or at least not in the near term) I wanted to document the minor issue before I forgot.
@hsoft
Copy link
Owner

@hsoft hsoft commented Dec 17, 2014

It's better if such issues are fixed separately. This way, the fix can be part of v2.8.2 (#26 will only be in 2.9)
brownnrl added a commit to brownnrl/moneyguru that referenced this issue Dec 27, 2014
@brownnrl
(hsoft#406) No operation editor for will_import column
2b69580 
A NO_EDIT constant was added to the ``qt.conroller.table`` module.
When this is seen, the createEditor method will return None
(http://qt-project.org/forums/viewthread/9541).
brownnrl added a commit to brownnrl/moneyguru that referenced this issue Dec 27, 2014
@brownnrl
(hsoft#406) No operation editor for will_import column
c0e0ba0 
A NO_EDIT constant was added to the ``qt.conroller.table`` module.
When this is seen, the createEditor method will return None
(http://qt-project.org/forums/viewthread/9541).
@brownnrl
Copy link
Contributor Author

@brownnrl brownnrl commented Dec 27, 2014

Created pull request #410. Sorry about the double-up commit references, I must have accidentally merged some working copies with my master. Had to revert back to the 2.8.1 release
@hsoft
Copy link
Owner

@hsoft hsoft commented Dec 27, 2014

Once again, an elegant solution, thanks. I've verified that it works and merged it.
@hsoft hsoft closed this Dec 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@hsoft @brownnrl