Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop relying on currency.hardcoded.net #415

Closed
hsoft opened this issue Jan 4, 2015 · 4 comments
Closed

Stop relying on currency.hardcoded.net #415

hsoft opened this issue Jan 4, 2015 · 4 comments
Assignees
Labels

Comments

@hsoft
Copy link
Owner

@hsoft hsoft commented Jan 4, 2015

I don't want to have to maintain that server forever. We can query the Bank of Canada and Yahoo directly from moneyGuru.

@brownnrl
Copy link
Contributor

@brownnrl brownnrl commented Jan 4, 2015

Is it possible to post the server code in a separate repo for analysis and for posterity's sake? I know that is probably still proprietary, and probably isn't too complicated just some XML RPCs right? But would be interesting to see. I haven't looked at that portion too closely.

@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jan 5, 2015

@hsoft
Copy link
Owner Author

@hsoft hsoft commented Jun 23, 2015

Alright, let's do this (after #429). The task is rather simple: take the fetch_boc_rates unit from the currency server and implement it as a moneyguru plugin.

Oh, I see that the link I gave earlier is now a 404. Sorry about that, I think I mistakenly erased it recently. I'll git-ify it and push it on github.

As a bonus, I think I'll improve the "Currency Rates" plugin to include the last fetch date so we can more easily debug currency fetching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants