New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse dialog instances #434

Closed
hsoft opened this Issue Jul 6, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@hsoft
Owner

hsoft commented Jul 6, 2015

Under the Qt UI, all dialogs are pre-instantiated at startup and reused throughout the app run. This brings all kinds of little glitches, such as #433.

Dialogs should be instantiated on-the-fly, when they're invoked by the user, and then destroyed. This will get us rid of a whole class of little problems.

@hsoft hsoft added feature qt labels Jul 6, 2015

@hsoft hsoft added this to the v2.10 milestone Jul 6, 2015

hsoft added a commit that referenced this issue Jul 6, 2015

Make BudgetPanel's instantiation "on-the-fly"
I start my "on-the-fly" adventure with the simplest one. It's a rather
tricky move, especially on the test side. I had to start weakref-ing my
references in dialogs so that instances would be properly deleted after
closing a dialog.

ref #434

@hsoft hsoft self-assigned this Jul 18, 2015

@hsoft hsoft closed this in 1ac3b64 Jul 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment