New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin management view #451

Closed
hsoft opened this Issue Jan 17, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@hsoft
Owner

hsoft commented Jan 17, 2016

Create a new view that lists all available plugins in a table, along with their type (table, currency, import) and a checkbox to enable or disable them. All core plugins are enabled by default, but user plugins have to be manually enabled.

I'm not sure yet, but I expect that enabling/disabling a plugin while the application is running brings its share of complications, so for now, we'll avoid this and only load plugins at initialization time. This means that we'll need a label that says that restarting moneyGuru is needed for plugin preferences to be taken into account.

There should also be an "open plugins folder" button.

This is a part of the big plugin architecture overhaul at #401.

@hsoft hsoft added this to the v2.10 milestone Jan 17, 2016

@hsoft hsoft self-assigned this Jan 17, 2016

@hsoft

This comment has been minimized.

Owner

hsoft commented Jan 18, 2016

Note to myself: as I implement this, I'm testing plugin enabling/disabling and I realize that when loading a document containing references to unsupported currencies (because of a disabled currency provider), we silently change them to the native currency. This wasn't much of a problem before because it wasn't possible to disable a core currency provider, but if left as is, this will probably be a serious problem. We'll need to refuse loading a document that contains reference to unsupported currencies to avoid potential data loss.

hsoft added a commit that referenced this issue Jan 31, 2016

Refuse to load moneyguru files containing unsupported currencies
With the new plugin management feature coming, it becomes easy to
mistakenly disable currency providers. If we do that and then load a
file containing a now-unsupported currency, we would previously silently
use our default currency. That's bad because the user could then save
the file and lose all currency information. We really don't want this to
happen.

ref #451

hsoft added a commit that referenced this issue Jan 31, 2016

Add missing test file
Oops, forgot to include it in previous commit.

ref #451

hsoft added a commit that referenced this issue Jan 31, 2016

Add plugin management view
qt-only for now. ref #451

@hsoft hsoft closed this in a6e4b6a Feb 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment