Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV File Target Selection doesn't carry to import screen #513

Closed
brownnrl opened this issue May 13, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@brownnrl
Copy link
Contributor

commented May 13, 2019

While checking to see if an import bug in 2.13.1 involving binding dates forward and backward in time against existing transaction presented itself in 3.0.0 (it did not), I noticed that if you select a target account in the CSV file importer, the account entries from the target account appear, but the target account combo selector on the import window remains at the default entry prompting the user to select an account. Not re-selecting the correct account at the import window (which if done resets all the bindings), results in the stack trace below once import is selected.

Application Name: moneyGuru
Version: 3.0.0

Traceback (most recent call last):
  File "/home/nelson/projects/moneyguru/qt/controller/import_/window.py", line 137, in targetAccountChanged
    self.model.selected_target_account_index = index
  File "/home/nelson/projects/moneyguru/core/gui/import_window.py", line 397, in selected_target_account_index
    self.selected_pane.selected_target = target
AttributeError: 'NoneType' object has no attribute 'selected_target'

hsoft added a commit that referenced this issue May 14, 2019

@hsoft

This comment has been minimized.

Copy link
Owner

commented May 14, 2019

Thanks, does it work better with the commit above?

@hsoft

This comment has been minimized.

Copy link
Owner

commented May 20, 2019

I will suppose that it does and release 3.0.1

@hsoft hsoft closed this May 20, 2019

@brownnrl

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2019

Sorry, I was on travel, it does work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.