New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Save As" using mangled docpath which saves file under the cwd. (#465) #466

Merged
merged 1 commit into from Jul 22, 2016

Conversation

Projects
None yet
2 participants
@tuxlifan
Contributor

tuxlifan commented Jul 19, 2016

Similar to #461 the change in behaviour for QFileDialog.getSaveFileName
caused the new file to be created in a directory named "('" under the
current working directory and included some potentially hard to cleanup
characters in the path.

Fixes #465.
(Tested on Linux only)

Fix "Save As" using mangled docpath which saves file under the cwd.
Similar to #461 the change in behaviour for QFileDialog.getSaveFileName
caused the new file to be created in a directory named "('" under the
current working directory and included some potentially hard to cleanup
characters in the path.
@hsoft

This comment has been minimized.

Owner

hsoft commented Jul 21, 2016

Thanks for this PR. That's nasty indeed. I'll test it soon (I hope) and will follow with a minor release shortly.

@hsoft

This comment has been minimized.

Owner

hsoft commented Jul 22, 2016

In fact, it's exactly the same bug (and fix) as in #461, but at another place. Merging.

@hsoft hsoft merged commit b554b41 into hsoft:master Jul 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment