Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request(safari): Pinned Tab Icons support #686

Closed
Kristinita opened this issue Mar 7, 2018 · 7 comments
Closed

feature request(safari): Pinned Tab Icons support #686

Kristinita opened this issue Mar 7, 2018 · 7 comments
Milestone

Comments

@Kristinita
Copy link

Kristinita commented Mar 7, 2018

1. Summary

If user have in HTML constructions as:

<link rel="mask-icon" href="SashaSVG.svg" color="red">

It would be nice, if user don't get a warning:

line 6 column 9 - Warning: <link> proprietary attribute "color"

2. Argumentation

See Creating Pinned Tab Icons page on official Apple site.

Another validation tools already support color attribute, see related issues:

Thanks.

@balthisar
Copy link
Member

See the option warn-proprietary-attributes for instant resolution.

@geoffmcl
Copy link
Contributor

geoffmcl commented Mar 8, 2018

@Kristinita thanks for the issue...

Have not read any W3C documentation on this, but like the nu validator, @sideshowbarker, have added TidyAttr_COLOR to the W3CAttrsFor_LINK that governs attributes allowed for TidyTag_LINK... and pushed the change db02d45 to the issue-686 branch... this seems to remove the warning...

Have run our Regression Tests and no problem, but this may just mean there is no existing test for this...

Look forward to futher feedback on whether this should be merged to next... thanks...

@geoffmcl geoffmcl added this to the 5.7 milestone Mar 8, 2018
geoffmcl added a commit that referenced this issue Apr 19, 2018
Is #686 - Add attr COLOR to W3CAttrsFor_LINK - PR #701
geoffmcl added a commit that referenced this issue Apr 19, 2018
@geoffmcl
Copy link
Contributor

Now PR #701 merged so closing this... thanks @Kristinita ...

@Kristinita
Copy link
Author

@geoffmcl , when 5.7 version will released?

Thanks.

@geoffmcl
Copy link
Contributor

@Kristinita there will be no 5.7 release. Read the VERSION.md... especially the Minor odd/even numbering...

The next 5.8 release is presently arbitrarily targeted for May 24, 2018, but we will see what happens as that draws near...

Agree it is a bit odd that the milestone is called 5.7, when it should be 5.8... and will shortly create a 5.10 milestone, so I can begin to move issues not likely to be closed in 5.8 to that...

In the past this has usually slipped somewhat for various reasons... but we will see... thanks...

@Kristinita
Copy link
Author

5.6.0 is latest release for February 2019. We wait a new release.

Thanks.

@Kristinita
Copy link
Author

@geoffmcl , in September 2020 we are waiting for version 5.8.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants