Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant blank lines when printing -help #781

Closed
brlin-tw opened this issue Nov 29, 2018 · 1 comment
Closed

Redundant blank lines when printing -help #781

brlin-tw opened this issue Nov 29, 2018 · 1 comment

Comments

@brlin-tw
Copy link
Contributor

brlin-tw commented Nov 29, 2018

Refer the following screenshot:

default

There are two redundant blank lines before the actual -help content (in 5.2.0 there was only one but now there are two), which is not pretty IMO.

I would suggest keep no blank lines at all or only one blank line, if there's any reason to do so.

@geoffmcl
Copy link
Contributor

@Lin-Buo-Ren this is certainly your preference, but I wonder whether it is universal... maybe...

Wandering back in history, the original tidy creators certainly liked redundant blank lines... and I sort of got used to them, even liked them... over the years some have been eliminated in the pretty print output, but can sometimes be restored by --vertical-space yes, referred to as classic mode in the code, but not all... but maybe not at all relevant here...

You are just referring to -h text...

Back at 5.2.0, 5.4.0 there was only 1... and maybe more important, back in tidy-2000 and tidy-2009 there were none...

So this does feel like redundant blank line creep in help... nothing to do with classic mode...

So, in general, could go for PR #782, a very limited change...

What do others think? Look forward to further feedback... thank...

geoffmcl added a commit that referenced this issue Mar 29, 2019
…nes-in-help

PR #782 - Drop redundant blank lines in -help - closes #781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants