Tidy 5.7.20 crashes if allocator replaced #797

Activity

1. geoffmcl commented on Jan 28, 2019

   

   geoffmcl

   on Jan 28, 2019

   Contributor

   More actions

   @dd8 thanks for catching this not very obvious bug... but easy to see, when you know what to look for...

   Given that libTidy has a memory TidyAllocator, that users can set to what they want, realloc() should not be used in the raw, in those 2 cases...

   F:\Projects\tidy-html5>find /N ">list" src\*.c
   ---------- SRC\ATTRS.C
   [801]        priorities->list = realloc( priorities->list, sizeof(tmbstr) * priorities->capacity + 1 );
   and
   ---------- SRC\MESSAGE.C
   [1353]        list->list = realloc( list->list, sizeof(tidyStrings) * list->capacity + 1 );
   

   Will try to include this easy fix somewhere... unless someone beats me to it, with say a patch, or PR... thanks...
2. geoffmcl

   added

   Bug

   on Jan 28, 2019
3. dd8 commented on Jan 28, 2019

   

   dd8

   on Jan 28, 2019

   Author

   More actions

   I do have a patch which has been tested in production, so I can package that up and attach it to this issue
4. geoffmcl commented on Jan 28, 2019

   

   geoffmcl

   on Jan 28, 2019

   Contributor

   More actions

   @dd8 that would be appreciated... maybe I can then include it in the next merge I do... thanks...
5. dd8 commented on Jan 29, 2019

   

   dd8

   on Jan 29, 2019

   Author

   More actions

   Here's the patch
   patch-realloc.diff.txt

   Compiles in XCode 10 clang on Mac, Visual Studio 2015 on Windows
   Tested in production on macOS 10.13, macOS 10.14, Windows 7, Windows 10, Windows Server 2016

   Not tested on Linux/gcc
6. geoffmcl

   added a commit that references this issue on Jan 31, 2019

   Is #797 - use 'TidyRealloc' in place of raw 'realloc'

   e46435f
7. geoffmcl

   closed this as completedin 68a29fbon Jan 31, 2019
8. geoffmcl commented on Jan 31, 2019

   

   geoffmcl

   on Jan 31, 2019

   Contributor

   More actions

   @dd8 now applied, version 5.7.22... thanks...
9. ddkilzer

   added a commit that references this issue on Nov 11, 2024

   Is htacg#797 - Bump to 5.7.21 for this fix - closes htacg#797

   68a29fb