Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated warnings #938

Closed
da2x opened this issue Apr 13, 2021 · 7 comments
Closed

Outdated warnings #938

da2x opened this issue Apr 13, 2021 · 7 comments

Comments

@da2x
Copy link

da2x commented Apr 13, 2021

The following warnings are outdated as all of these attributes are specified in the current version of HTML5.

  • <a> proprietary attribute "referrerpolicy"
  • <iframe> proprietary attribute "allow"
  • <iframe> proprietary attribute "loading"
  • <img> proprietary attribute "decoding"
  • <img> proprietary attribute "loading"
  • <source> proprietary attribute "sizes"
  • <video> proprietary attribute "muted"
  • <video> proprietary attribute "playsinline"
@geoffmcl
Copy link
Contributor

@da2x, thank you for the issue, and research...

When you say, outdated, sadly, that may well be true... can you give W3C ref link(s) for each... thanks...

Like, for the first, referrerpolicy, current libTidy does not have this attribute listed, see Known HTML attributes, and the corresponding attribute_defs array, however I found the W3C referrer-policy link, and it seems this attribute should be supported on the a, area, img, iframe, or link elements, with an enumerated set of values, since at least 2017...

So would be relatively easy to ADD support... note the warning that the enum, and table must be in the same order... just add new items to the enum and array ends... see ATTRIBUTES.md for more details, but forget any alphabetic, or other, ordering, groupings... note, this md should be fixed, someday...

And, at this time, seems optional whether an attrIsXXXX(av) macro is added to attrs.h, but open about this...

Need the research, links, conclusions, ... for each case... and maybe a use sample, for testing... thanks...

Look forward to further feedback, comments, links, patches, PR, etc, etc... thanks...

@da2x
Copy link
Author

da2x commented Apr 13, 2021

I updated the above list with links to the relevant sections for each attribute in the current spec.

@geoffmcl
Copy link
Contributor

@da2x, thanks for the updated list, with whatwg links... did not check all, but those inspected looked good... and it seems in most cases, libTidy does not presently have these attributes listed...

Now all we need are the patches, PR's, to implement this ;=)) to bring libTidy up-to-date... thanks...

See CONTRIBUTING.md for details of forking, keeping that fork up-to-date, creating, and presenting a PR, in a branch, etc... Ask here, if further help needed... thanks...

@drichardson
Copy link
Contributor

Ask here, if further help needed... thanks...

@geoffmcl I've had the PR #949 opened for about a month now... is there anything else I need to do to get it reviewed?

@balthisar
Copy link
Member

@drichardson, @geoffmcl is on sick leave; I'll get to it as soon as I can. It won't be closed, and I'm sorry I can't rush it, either, with a one month old son in the house!

balthisar added a commit that referenced this issue Jun 30, 2021
@balthisar
Copy link
Member

Closing as fixed via merge #949.

@Seirdy
Copy link

Seirdy commented Jul 26, 2023

@balthisar This issue doesn't seem fixed; several attributes enumerated in the original filing don't appear to be supported, such as referrerpolicy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants