Add support for 'role' attribute. #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for 'role' attribute for all HTML elements except: - those elements that are obsolete in HTML5. (See a list of all HTML5 elements here: http://dev.w3.org/html5/markup/elements.html) - those elements that can have "no role" AND have strong native semantics. See http://www.w3.org/html/wg/drafts/html/master/dom.html#sec-strong-native-semantics (The only exception to this exception is the "input" element.)
|
👍 |
|
@saadatm, this has been pulled into develop-500 branch, and so I will close this PR. Unfortunately due to the complexity of all of the neglected PR's over the years, the PR history is a bit fractured. This means that your name won't be shown in the commit history, but the links for the commits will still link back to this PR so that you will still have acknowledgements for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for 'role' attribute for all HTML elements except:
The commit does not check for valid 'role' values.