Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #437 - re-use of 'wrap-php' option #645

Merged
merged 1 commit into from
Nov 22, 2020
Merged

Issue #437 - re-use of 'wrap-php' option #645

merged 1 commit into from
Nov 22, 2020

Conversation

geoffmcl
Copy link
Contributor

@geoffmcl geoffmcl commented Nov 7, 2017

Review, testing and feedback welcome... thanks...

@geoffmcl geoffmcl mentioned this pull request Nov 7, 2017
@balthisar
Copy link
Member

@geoffmcl, testing is okay, but see followup discussion in #437.

@balthisar
Copy link
Member

@geoffmcl, I merged the others, but didn't merge this one in case you want to change the scope based on #437 additional discussion.

@geoffmcl
Copy link
Contributor Author

@balthisar see more discussion in #437...

@geoffmcl
Copy link
Contributor Author

@balthisar another plea #437 for just a yes or no reply...

@balthisar
Copy link
Member

@geoffmcl, go for it. We can open inconsistencies as future issues. Yes, this is ad hoc, but let it happen. We can do logical engineering later.

@geoffmcl geoffmcl merged commit f49386e into next Nov 22, 2020
@geoffmcl geoffmcl deleted the issue-437 branch November 22, 2020 15:44
@geoffmcl
Copy link
Contributor Author

@balthisar ok, went for it ;=))

geoffmcl added a commit that referenced this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants