Skip to content

Is #673 - Revert 350f7b4 and 86e62db AdjustConfig logic#705

Merged
geoffmcl merged 1 commit into
nextfrom
issue-673
Apr 21, 2018
Merged

Is #673 - Revert 350f7b4 and 86e62db AdjustConfig logic#705
geoffmcl merged 1 commit into
nextfrom
issue-673

Conversation

@geoffmcl

@geoffmcl geoffmcl commented Mar 29, 2018

Copy link
Copy Markdown
Contributor

While these look like a code cleanup, they appear to have an adverse consequence in the use of libtidy by PHP 7+, so have been reverted. Changes in -

modified:   src/config.c
modified:   src/config.h
modified:   src/tidylib.c

As indicated while these look like seemingly innocuous changes in AdjustConfig logic, it has caused some very undesirable changes... see #704 for more details...

As stated in #673, unless a better fix is found will consider merging the issue-673 to next...

Look forward to further feedback... thanks...

While these look like a code cleanup, they appear to have an adverse
consequence in the use of libtidy by PHP 7+, so have been reverted.

	modified:   src/config.c
	modified:   src/config.h
	modified:   src/tidylib.c
@geoffmcl

Copy link
Copy Markdown
Contributor Author

This seems related to #780 - looks like a prob. with wrap => 0, which seemed broken in 5.6, fixed in 5.7.9, and so is in current next...

If someone had the time to cherry pick this fix back into the 5.6, and issue a 5.6.1 release, that would be great...

But given that we have some difficulty in making a new release 5.8, or 6.0, given #743, that does not seem likely to happen... I don't know how to fix that... see stalled #741...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant