Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against NULL in PruneSection. #853

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Protect against NULL in PruneSection. #853

merged 1 commit into from
Oct 2, 2020

Conversation

esclim
Copy link
Contributor

@esclim esclim commented Dec 18, 2019

A Null node happens when pruning unbalanced <![if ...]> <![endif]>.

Protect against NULL in PruneSetion.
 A Null node happens when pruning unbalanced <![if ...]> <![endif]>.
@esclim
Copy link
Contributor Author

esclim commented Dec 18, 2019

Sample HTML file and config file.
test.zip

@esclim esclim changed the title Protect against NULL in PruneSetion. Protect against NULL in PruneSection. Dec 18, 2019
@geoffmcl
Copy link
Contributor

@esclim after a quick test, with your supplied sample... thanks for that...

Looks like a good catch, and fix... of a bug just waiting to happen... thanks...

@geoffmcl geoffmcl added the Bug label Dec 18, 2019
@geoffmcl
Copy link
Contributor

geoffmcl commented Oct 1, 2020

@esclim, sorry for the delay...

Have added your sample to my repo, as in_853.html and cfg_853.txt ... so I could pull, and test in linux...

$ tidy -v
HTML Tidy for Linux version 5.7.28
$ tidy -config test/input5/cfg_853.txt test/input5/in_853.html
line 3 column 6 - Warning: inserting missing 'title' element
Segmentation fault (core dump)

WOW, there, this BUG causes a segfault!!!

Must get to merging this PR soonest... thanks...

@geoffmcl geoffmcl merged commit 089d14a into htacg:next Oct 2, 2020
geoffmcl added a commit that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants