Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is. #681 - read-only files, and dirs #926

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Is. #681 - read-only files, and dirs #926

merged 1 commit into from
Apr 14, 2021

Conversation

geoffmcl
Copy link
Contributor

Please test, and report/comment in issue #681... thanks...

@jmadiot
Copy link

jmadiot commented Mar 29, 2021

Hello, thank you for the fix! This fixes the problem for me (linux). I detail here what I did for @geoffmcl to check that I correctly tested and maybe to make it easier for others to test:

mkdir /tmp/testtidy
cd /tmp/testtidy
git clone https://github.com/htacg/tidy-html5.git
cd tidy-html5/
git switch issue-681
cd build/cmake/
cmake ../.. -DCMAKE_BUILD_TYPE=Release
make
echo "foo" > foo.html
./tidy foo.html
# correct output
chmod -w foo.html
./tidy foo.html
# also correct output!
# I also check that the branch next had the problem:
git switch next
make
./tidy foo.html
# expectedly got the error of issue 681: Document: "foo.html" is not a file!
chmod +w foo.html
./tidy foo.html
# normal output again

@geoffmcl geoffmcl merged commit 957ee4a into next Apr 14, 2021
@geoffmcl geoffmcl deleted the issue-681 branch April 14, 2021 16:02
geoffmcl added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants