simple fix for the range of the condition. #953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple fix for the range of the condition.
Member
|
@ihsinme, is there a bug associated with this? Can you provide a failing testcase for current behavior, and a passing testcase with your changes? I'm not a character encoding expert, and your change is to some very old, presumed stable code, so I'd really like you to coach me on what this is supposed to do. Thanks. |
Contributor
Author
|
good day. and to optimize the code to correct the condition correctly. |
Member
|
@ihsinme, thanks, I see. I should have looked a bit more closely! I'll merge this then bump the version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple fix for the range of the condition.