Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple fix for the range of the condition. #953

Merged
merged 1 commit into from
Jun 30, 2021
Merged

simple fix for the range of the condition. #953

merged 1 commit into from
Jun 30, 2021

Conversation

ihsinme
Copy link
Contributor

@ihsinme ihsinme commented Jun 13, 2021

simple fix for the range of the condition.

simple fix for the range of the condition.
@balthisar
Copy link
Member

@ihsinme, is there a bug associated with this? Can you provide a failing testcase for current behavior, and a passing testcase with your changes?

I'm not a character encoding expert, and your change is to some very old, presumed stable code, so I'd really like you to coach me on what this is supposed to do.

Thanks.

@ihsinme
Copy link
Contributor Author

ihsinme commented Jun 30, 2021

good day.
in this code, everything is just if (159 <c && c <191) does not restrict rigidly. in fact, for c equal to 160,161,162,163, the switch has no handlers.

and to optimize the code to correct the condition correctly.

@balthisar
Copy link
Member

@ihsinme, thanks, I see. I should have looked a bit more closely! I'll merge this then bump the version.

@balthisar balthisar merged commit 4f6c723 into htacg:next Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants