Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed merge conflict; fixed non-build issue on macOS. RC for testing. #965

Merged
merged 1 commit into from Jul 10, 2021

Conversation

balthisar
Copy link
Member

No description provided.

@balthisar
Copy link
Member Author

This is an updated version of issue-743 branch, with a slight fix to build on macOS, and fixes a merge conflict resulting from another improvement in the base repo. It passes all regression tests, but more importantly, it passes all of the API tests that I have written in Swift in another repository. At some point I may make those tests public.

Thanks, @geoffmcl for all the dirty work on this one.

@balthisar balthisar merged commit 47159bd into next Jul 10, 2021
@balthisar balthisar deleted the issue-743-rc branch July 10, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant