Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htmap 0.6.1 incompatible with click 8.1 #244

Closed
duncanmmacleod opened this issue Oct 20, 2022 · 0 comments · Fixed by #245
Closed

htmap 0.6.1 incompatible with click 8.1 #244

duncanmmacleod opened this issue Oct 20, 2022 · 0 comments · Fixed by #245
Labels
bug Something isn't working

Comments

@duncanmmacleod
Copy link
Contributor

Describe the bug

htmap 0.6.1 is incompatible with click 8.1 due to use of the autocompletion parameter to click.argument() that we deprecated in pallets/click#1622 (released as 8.0) and removed in pallets/click#2130 (8.1):

$ htmap --help
Traceback (most recent call last):
  File "/home/duncan/./tmpenv/bin/htmap", line 5, in <module>
    from htmap.cli import cli
  File "/home/duncan/tmpenv/lib/python3.10/site-packages/htmap/cli.py", line 314, in <module>
    def wait(tags, pattern, all):
  File "/home/duncan/tmpenv/lib/python3.10/site-packages/htmap/cli.py", line 272, in _multi_tag_args
    func = a(func)
  File "/home/duncan/tmpenv/lib/python3.10/site-packages/click/decorators.py", line 287, in decorator
    _param_memo(f, ArgumentClass(param_decls, **attrs))
  File "/home/duncan/tmpenv/lib/python3.10/site-packages/click/core.py", line 2950, in __init__
    super().__init__(param_decls, required=required, **attrs)
TypeError: Parameter.__init__() got an unexpected keyword argument 'autocompletion'

To Reproduce

python3 -m venv tmpenv
./tmpenv/bin/python -m pip install -q htmap "click>=8.1"
./tmpenv/bin/htmap --help

Expected behavior
No errors.

Software Versions:
Include the results of running each of the following from the command line:

  • python -c "import htcondor, htmap; print(htcondor.version()); print(htmap.version())" (can run the part in " directly inside Python if desired)
    console $ ./tmpenv/bin/python -c "import htcondor, htmap; print(htcondor.version()); print(htmap.version())" $CondorVersion: 9.12.0 2022-10-06 BuildID: UW_Python_Wheel_Build $ HTMap version 0.6.1
  • condor_version
  • cat /etc/os-release
  • cat /proc/version

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@duncanmmacleod duncanmmacleod added the bug Something isn't working label Oct 20, 2022
duncanmmacleod added a commit to duncanmmacleod/htmap that referenced this issue Oct 20, 2022
duncanmmacleod added a commit to duncanmmacleod/htmap-feedstock that referenced this issue Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant