Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TemporalMemory extra to externalPredictiveInputs #519

Merged
merged 3 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@ctrl-z-9000-times
Copy link

commented Jun 17, 2019

There was confusion about what this feature does so I renamed it
for clarity.

See also issue #512.

Rename TemporalMemory extra to externalPredictiveInputs
There was confusion about what this feature does so I renamed it
for clarity.
@breznak
Copy link
Member

left a comment

Looks good, thanks!
Consider some more details for the description..?

Show resolved Hide resolved src/htm/algorithms/TemporalMemory.hpp
@breznak
Copy link
Member

left a comment

Improved doc and clearer code is always the best!
Thanks

@@ -99,6 +99,11 @@ class TemporalMemory : public Serializable
* @param predictedSegmentDecrement
* Amount by which segments are punished for incorrect predictions.
*
* Note: A good value is just a bit larger than
* (the column-level sparsity * permanenceIncrement). So, if column-level

This comment has been minimized.

Copy link
@breznak

breznak Jun 20, 2019

Member

OT: #279 it would be nice to reduce the number of parameters for the algorithms, especially in cases like this where a good-enough value can be derived from other settings. Do you think this would be a reasonable candidate to hard-code?
Pros:

  • less space for user to mess up
  • faster parm optimizations
    Cons:
  • removes a bit of configurability

This comment has been minimized.

Copy link
@ctrl-z-9000-times

ctrl-z-9000-times Jun 20, 2019

Author

I agree, but here are two more potential issues:

  1. Is this advice always good? I think it would need further investigation before we remove the parameter in favor of this heuristic.
  2. We would have to modify every instance of the TM to omit this parameter. It would be a lot of work.

@breznak breznak merged commit 81902c0 into master Jun 20, 2019

3 of 4 checks passed

ci/circleci: arm64-build-test CircleCI is running your tests
Details
ci/circleci: build-and-test Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@breznak breznak deleted the rename-tm-extra branch Jun 20, 2019

@ctrl-z-9000-times ctrl-z-9000-times referenced this pull request Jun 20, 2019

Closed

Rename TM extra #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.