Fix build for ember-source 4.0+ #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI CI on the repo is very bad. I may need to rerun failures to get then green, if they don't look related. |
|
Best I can tell CI failures are unrelated for most of the versions but we may have broken 3.12/3.16/3.20 |
|
Uh. I hope we did not? Those versions are supported and the support is used by ember table and apps I work on. |
|
3.12, 16, and 20 are green in the builds. Why do you think they may be broken? |
|
@mixonic you missed I added a commit to fix them |
|
Ah, amazing. Thanks @runspired @wagenet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #393.
...or at least attempts to!