Permalink
Browse files

Removing ScrollTo on table of contents, it goes against everything we…

… are preaching about smooth jank-free performance
  • Loading branch information...
PaulKinlan committed Mar 14, 2013
1 parent 8a2b333 commit 7a9beac0fce84fe5dec7cb1a1810e16f087e4613
Showing with 1 addition and 2 deletions.
  1. +0 −1 content/profiles.html
  2. +1 −1 customtags/templatetags/templatefilters.py
View
@@ -6,7 +6,6 @@
<!--
<link type="text/css" rel="stylesheet" href="/static/css/profiles{% if prod %}.min{% endif %}.css"/>
-->
-<!--<script defer src="/static/js/jquery.scrollTo-min.js"></script>-->
<script src="/static/js/profiles{% if prod %}.min{% endif %}.js"></script>
{% endblock %}
{% block onload %}scrollToProfile();{% endblock %}
@@ -34,7 +34,7 @@ def render(self, context):
else:
output += "</li>"
level = entry['level']
- output += "<li><a href='#%s' onclick='$.scrollTo(\"#%s\", 800, {offset: {top: -35}})'>%s</a>" % (entry['id'], entry['id'], entry.get('text', ''))
+ output += "<li><a href='#%s'>%s</a>" % (entry['id'], entry.get('text', ''))
output += "</li></ul>" * level
return output

4 comments on commit 7a9beac

@ebidel

This comment has been minimized.

Show comment Hide comment
@ebidel

ebidel Mar 15, 2013

Owner

I think you missed removed the lib in the main template? Can you do a grep for jquery.scrollTo-min.js?

Owner

ebidel replied Mar 15, 2013

I think you missed removed the lib in the main template? Can you do a grep for jquery.scrollTo-min.js?

@cwilso

This comment has been minimized.

Show comment Hide comment
@cwilso

cwilso Mar 15, 2013

Contributor

Done and done: b66a074.

Contributor

cwilso replied Mar 15, 2013

Done and done: b66a074.

@PaulKinlan

This comment has been minimized.

Show comment Hide comment
@PaulKinlan

PaulKinlan Mar 15, 2013

Owner
Owner

PaulKinlan replied Mar 15, 2013

@ebidel

This comment has been minimized.

Show comment Hide comment
@ebidel

ebidel Mar 15, 2013

Owner

It's in app.js. IIRC, the feature page TOCs also do the same scroll effect. If it's janky, we should remove it everywhere.

Owner

ebidel replied Mar 15, 2013

It's in app.js. IIRC, the feature page TOCs also do the same scroll effect. If it's janky, we should remove it everywhere.

Please sign in to comment.