From 562645a0747286a4b5633975cfb474ac360602d5 Mon Sep 17 00:00:00 2001 From: shootaroo Date: Tue, 17 Dec 2013 19:16:39 +0900 Subject: [PATCH] Disable rule at false value --- src/core.js | 8 +++++--- test/rules/attr-lowercase.spec.js | 6 ++++++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/core.js b/src/core.js index eb8d4ddaf..3fad44255 100644 --- a/src/core.js +++ b/src/core.js @@ -36,9 +36,11 @@ var HTMLHint = (function (undefined) { var rules = HTMLHint.rules, rule; for (var id in ruleset){ - rule = rules[id]; - if (rule !== undefined){ - rule.init(parser, reporter, ruleset[id]); + if (ruleset[id]) { + rule = rules[id]; + if (rule !== undefined){ + rule.init(parser, reporter, ruleset[id]); + } } } diff --git a/test/rules/attr-lowercase.spec.js b/test/rules/attr-lowercase.spec.js index 8a42d7627..e5fbe1eec 100644 --- a/test/rules/attr-lowercase.spec.js +++ b/test/rules/attr-lowercase.spec.js @@ -29,4 +29,10 @@ describe('Rules: '+ruldId, function(){ expect(messages.length).to.be(0); }); + it('Set is false not result in an error', function(){ + var code = '

'; + ruleOptions[ruldId] = false; + var messages = HTMLHint.verify(code, ruleOptions); + expect(messages.length).to.be(0); + }); }); \ No newline at end of file