Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use selector to detect syntax #11

Merged
merged 2 commits into from Sep 27, 2018

Conversation

Projects
None yet
3 participants
@borela
Copy link
Contributor

borela commented Sep 27, 2018

Fixes: Compatibility with external HTML syntaxes that has a different name but the same root scope. Example: borela/naomi#173

馃毃 Please review the guidelines for contributing and our code of conduct to this repository. 馃毃
Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:

  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Short description of what this resolves:

Detect any HTML syntax by scope instead of name, this will enable the plugin to work with HTML4, HTML5, etc... syntaxes.

Proposed changes:

Add the selector and remove syntax name.

馃憤 Thank you!

@thedaviddias
Copy link
Member

thedaviddias left a comment

@borela can you make the corrections to pass the CI?

@borela borela force-pushed the borela-forks:use-selector branch 7 times, most recently from 139a17d to 69181c5 Sep 27, 2018

@borela borela force-pushed the borela-forks:use-selector branch from 69181c5 to 91d4ee2 Sep 27, 2018

@borela

This comment has been minimized.

Copy link
Contributor Author

borela commented Sep 27, 2018

I had to disable D211 because it was conflicting with D203, it seams to be the change that required the least amount of comestic changes to the current code style.

@thedaviddias

This comment has been minimized.

Copy link
Member

thedaviddias commented Sep 27, 2018

Ok. I think it's good for now.

@thedaviddias thedaviddias merged commit 89cc4d2 into htmlhint:master Sep 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mmaday

This comment has been minimized.

Copy link
Collaborator

mmaday commented Oct 1, 2018

馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.