Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing file #89

Closed
atomicbird opened this issue Oct 29, 2019 · 3 comments
Closed

Missing file #89

atomicbird opened this issue Oct 29, 2019 · 3 comments

Comments

@atomicbird
Copy link

@atomicbird atomicbird commented Oct 29, 2019

It looks like there's a file missing in the repo. On a fresh hugo install, after installing this theme, hugo reports:

% hugo
Building sites … ERROR 2019/10/29 16:41:04 render of "home" failed: execute of template failed: template: index.html:2:5: executing "header" at <partial "header.html" .>: error calling partial: "/private/tmp/quickstart/themes/hyde-hyde/layouts/partials/header.html:14:7": execute of template failed: template: partials/header.html:14:7: executing "partials/header.html" at <partial "header/custom.html">: error calling partial: partial "header/custom.html" not found
ERROR 2019/10/29 16:41:04 render of "taxonomyTerm" failed: execute of template failed: template: _default/list.html:2:7: executing "header" at <partial "header.html" .>: error calling partial: "/private/tmp/quickstart/themes/hyde-hyde/layouts/partials/header.html:14:7": execute of template failed: template: partials/header.html:14:7: executing "partials/header.html" at <partial "header/custom.html">: error calling partial: partial "header/custom.html" not found
Total in 84 ms
Error: Error building site: failed to render pages: render of "taxonomyTerm" failed: execute of template failed: template: _default/list.html:2:7: executing "header" at <partial "header.html" .>: error calling partial: "/private/tmp/quickstart/themes/hyde-hyde/layouts/partials/header.html:14:7": execute of template failed: template: partials/header.html:14:7: executing "partials/header.html" at <partial "header/custom.html">: error calling partial: partial "header/custom.html" not found

I can work around this with touch themes/hyde-hyde/layouts/partials/header/custom.html but I don't know what should be in that file.

@mpardalos

This comment has been minimized.

Copy link

@mpardalos mpardalos commented Oct 30, 2019

I'm getting the same, I think the intention is to have a hook for custom html in the header, but there should be a guard there checking that this custom html file (header/custom.html) exists.

{{ partial "header/feeds.html" . }}
{{ partial "header/custom.html" }}
</head>

@htr3n htr3n closed this in f7a755e Nov 1, 2019
@htr3n

This comment has been minimized.

Copy link
Owner

@htr3n htr3n commented Nov 1, 2019

@atomicbird thanks for reporting the bug. It was my fault to merge the PR [#84] without re-testing the style. I've just fixed this by adding an empty placeholder file custom.html. Please pull and check again. Thanks.

@atomicbird

This comment has been minimized.

Copy link
Author

@atomicbird atomicbird commented Nov 1, 2019

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.