Skip to content

Hugo Tavares Reis
htr

  • Hamburg, Germany
  • Joined on Dec 11, 2008
Apr 28, 2016
Apr 19, 2016
htr commented on pull request giantswarm/mayu#47
@htr

where is reconfigureHosts used ? apart from this, LGTM

Apr 18, 2016
htr commented on pull request giantswarm/mayu#47
@htr

no veto.

Apr 18, 2016
htr closed pull request giantswarm/fleet#4
@htr
GS 2 [WIP]
Apr 18, 2016
htr closed pull request giantswarm/fleet#1
@htr
unify etcd watches
Apr 18, 2016
htr closed pull request giantswarm/fleet#2
@htr
Htr experiments wip
Apr 18, 2016
htr closed pull request giantswarm/fleet#3
@htr
unify etcd watches
Apr 18, 2016
htr commented on pull request giantswarm/fleet#23
@htr

yup

Apr 18, 2016
htr commented on pull request giantswarm/fleet#31
@htr

yup

Apr 18, 2016
htr commented on pull request giantswarm/fleet#10
@htr

yup

Apr 18, 2016
htr commented on pull request giantswarm/mayu#47
@htr

for me the reconfigure should be implicit when a host's state changed

Apr 14, 2016
htr commented on pull request giantswarm/mayu#47
@htr

no practical side-effects. This is the way to go without replacing the whole dnsmasq.

Apr 14, 2016
htr commented on pull request giantswarm/mayu#47
@htr

ok, checked the whole diff. dnsmasq has to be restarted :)

Apr 14, 2016
htr commented on pull request giantswarm/mayu#47
@htr

using the API to change the state should be enough.

Apr 7, 2016
Mar 31, 2016
htr commented on pull request giantswarm/fleet#30
@htr

Lgtm

Mar 31, 2016
htr commented on pull request giantswarm/fleet#29
@htr

ping @hectorj2f

Mar 31, 2016
htr commented on pull request giantswarm/fleet#28
@htr

LGTM

Mar 30, 2016
htr opened pull request giantswarm/fleet#29
@htr
WIP grpcagent: resend unit states after connecting to a new engine
1 commit with 89 additions and 2 deletions
Mar 30, 2016
Mar 30, 2016
htr commented on pull request giantswarm/fleet#27
@htr

lgtm, didn't test

Mar 21, 2016
htr commented on pull request giantswarm/fleet#21
@htr

WFM

Mar 17, 2016
htr commented on pull request giantswarm/fleet#21
@htr

overall lgtm, but I suggest changing the etcdStatusUpdate to hasNonGRPCAgents

Mar 17, 2016
htr commented on pull request giantswarm/fleet#21
@htr

you can break right after this.

Mar 15, 2016
htr commented on pull request giantswarm/nomi#20
@htr

Yup. Lgtm

Mar 9, 2016
htr commented on pull request giantswarm/mayu#40
@htr

nop, let's keep this. the http bind addr might be something like "0.0.0.0".

Mar 9, 2016
htr commented on pull request giantswarm/nomi#20
@htr

sure, but that's much less practical then having a script doing things like for intervals in 10 100 500 100 do ssh core@remote ./fleemmer -addr=10.…

Mar 8, 2016
htr commented on pull request giantswarm/nomi#20
@htr

I only used the raw-instructions. I like the simplicity of scp-ing a binary once, run it with different instructions, get useful output to stderr/o…

Mar 4, 2016
htr commented on pull request giantswarm/fleet#18
@htr

LGTM

Feb 29, 2016
htr commented on pull request giantswarm/yochu#16
@htr

why was it there before?

Something went wrong with that request. Please try again.