optionally suppress server header? #129

Closed
zentrope opened this Issue Mar 6, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@zentrope

zentrope commented Mar 6, 2014

Some operations folks require that the server header be suppressed for various deployments. You can do this with Jetty:

(jetty/run-jetty routes
                 {:port port 
                  :join? false
                  :configurator #(.setSendServerVersion % false)})

Any interest in supporting this feature with http-kit's server? Just an extra flag, perhaps?

@BorePlusPlus

This comment has been minimized.

Show comment Hide comment
@BorePlusPlus

BorePlusPlus Apr 1, 2014

I'd be interested in that as well. Sometimes you don't want to share what server implementation you're running.

I'd be interested in that as well. Sometimes you don't want to share what server implementation you're running.

@jcf

This comment has been minimized.

Show comment Hide comment
@jcf

jcf May 1, 2014

I'd make use of this feature if it were made available. Is there interest in accepting a pull request that implements this?

headers.put("Server", "http-kit");

jcf commented May 1, 2014

I'd make use of this feature if it were made available. Is there interest in accepting a pull request that implements this?

headers.put("Server", "http-kit");

@ptaoussanis

This comment has been minimized.

Show comment Hide comment
@ptaoussanis

ptaoussanis Dec 16, 2015

Owner

A pull request would be welcome, thanks!

Owner

ptaoussanis commented Dec 16, 2015

A pull request would be welcome, thanks!

@ptaoussanis

This comment has been minimized.

Show comment Hide comment
@ptaoussanis

ptaoussanis Mar 2, 2016

Owner

Closing this issue for inactivity, please feel free to reopen if anyone would like to submit a PR - thanks!

Owner

ptaoussanis commented Mar 2, 2016

Closing this issue for inactivity, please feel free to reopen if anyone would like to submit a PR - thanks!

@ptaoussanis ptaoussanis closed this Mar 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment