Default HttpClient callback thread pool is always one #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the default corePoolSize to the number of available
processors.
The default thead pool for running the http client async callbacks is
initialized with a coreSize of 0 and a unbounded queue. The
ThreadPoolExecutor creates threads just if all the coreSize threads are
busy and the queue is full. Given that the default queue is unbounded,
new threads are never created, hence the default-pool will never ever
have more than 1 thread to execute all the callbacks.
From the ThreadPoolExecutor doc (http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadPoolExecutor.html):
"Using an unbounded queue (for example a LinkedBlockingQueue without a predefined capacity) will cause new tasks to wait in the queue when all corePoolSize threads are busy. Thus, no more than corePoolSize threads will ever be created"