Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to specify custom http headers #28

Merged
merged 4 commits into from Nov 12, 2012

Conversation

Projects
None yet
4 participants
@luk-
Copy link
Contributor

commented Nov 11, 2012

There have been a couple situations where I'm using this module and wishing I could quickly specify custom http headers in the options argument. This allows that. Added a test for it, existing tests pass.

@coderarity

This comment has been minimized.

Copy link

commented on lib/http-server.js in a1611d6 Nov 11, 2012

is a semicolon appropriate in an Object like this?

@coderarity

This comment has been minimized.

Copy link

commented Nov 11, 2012

needs documentation, too. =D

@luk-

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2012

haha, whoops, I get a little semicolon crazy trying to match your style. I'll add some docs as well

@luk-

This comment has been minimized.

Copy link
Contributor Author

commented Nov 11, 2012

Didn't add docs because there's no programmatic usage documentation as it is.

mmalecki added a commit that referenced this pull request Nov 12, 2012

Merge pull request #28 from st-luke/http-headers
Added support to specify custom http headers

@mmalecki mmalecki merged commit a0d5419 into http-party:master Nov 12, 2012

@mmalecki

This comment has been minimized.

Copy link
Contributor

commented Nov 12, 2012

Merged. Thanks Luke.

@jycabrera0628

This comment has been minimized.

Copy link

commented Apr 28, 2015

I am trying to add csp to my website, for this I am using http-server, how can I create custom http header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.