Skip to content

/ node-http-proxy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix modify response middleware example #1139

Merged
merged 3 commits into from Aug 22, 2019
Merged

Fix modify response middleware example #1139

merged 3 commits into from Aug 22, 2019

Conversation

@costolo
Copy link
Contributor

@costolo costolo commented Feb 8, 2017

This PR simply fixes the modifyResponse-middleware example to work properly by removing a deprecated function call (connect.createServer()) and passing the middleware functions to an http server.
costolo added 3 commits Feb 8, 2017
@costolo
declare app variable to house middleware
136ae9e
@costolo
remove deprecated connect.createServer() function call
73f6c90
@costolo
specify middleware with app.use() and pass app middleware to an http
Loading status checks…
0e88874 
server
@indexzero
indexzero approved these changes Aug 22, 2019
View changes
@indexzero indexzero merged commit b4028ba into http-party:master Aug 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
This was referenced Sep 5, 2020
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
@reposman33 reposman33 mentioned this pull request Sep 7, 2020
Merged
This was referenced Sep 8, 2020
Merged
Open
@pngithub pngithub mentioned this pull request Sep 9, 2020
Merged
@jherdman jherdman mentioned this pull request Sep 9, 2020
Merged
This was referenced Sep 9, 2020
Open
Open
@hrEh0002 hrEh0002 mentioned this pull request Sep 9, 2020
Open
@pngithub pngithub mentioned this pull request Sep 9, 2020
Merged
This was referenced Sep 9, 2020
Merged
Merged
Open
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 10, 2020
Open
@rcrdlbl rcrdlbl mentioned this pull request Sep 12, 2020
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2020
Open
@tvmogul tvmogul mentioned this pull request Oct 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indexzero indexzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@costolo @indexzero
You can’t perform that action at this time.