Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Changelog #1373

Merged
merged 1 commit into from Sep 5, 2019
Merged

Auto Changelog #1373

merged 1 commit into from Sep 5, 2019

Conversation

jsmylnycky
Copy link
Contributor

@jsmylnycky jsmylnycky commented Aug 23, 2019

  • Added in auto-changelog module set to keepachangelog format
  • Removed last nodejitsu reference

I have note used auto-changelog before, but it seems pretty useful and the formatting it performed looked about as good as one could hope. If you would prefer a different format, just let me know and I'll be happy to change it :) It should be wired up to automatically rebuild the changelog with the correct package.json version whenever npm version is ran.

I also went through all of the most recent merges into Master and everything looked pretty good to me. The only things I caught were the nodejitsu reference, and I updated the engines block in package.json to conform to the travis-ci Node environments.

@jsmylnycky jsmylnycky requested review from indexzero and jcrugzz Aug 23, 2019
@jsmylnycky
Copy link
Contributor Author

jsmylnycky commented Aug 28, 2019

@jcrugzz @indexzero If one of you guys can sign off on this, we can go ahead and get this merged, cut a release, and then I'll work on getting some of the other PRs reviewed & merged to master.

@jcrugzz
Copy link
Contributor

jcrugzz commented Aug 29, 2019

@jsmylnycky I think this looks reasonable. @indexzero is on vacation so lets give him a day to see if he pops on here, otherwise ill merge. Thanks for this!

@jsmylnycky
Copy link
Contributor Author

jsmylnycky commented Sep 4, 2019

@jcrugzz @indexzero /poke :)

Copy link
Contributor

@indexzero indexzero left a comment

Haven't used auto-changelog, but it's certainly a nice thing to automate 👍

jcrugzz
jcrugzz approved these changes Sep 5, 2019
@jsmylnycky
Copy link
Contributor Author

jsmylnycky commented Sep 5, 2019

Merging, feel free to cut a release when you're ready!

@jsmylnycky jsmylnycky merged commit 6e4bef4 into master Sep 5, 2019
@jcrugzz jcrugzz deleted the feature/autochangelog branch Sep 6, 2019
This was referenced Mar 17, 2021
Copy link

@calbearox calbearox left a comment

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

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants