Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Tokio 0.2 #307

Closed
wants to merge 128 commits into from
Closed

Port to Tokio 0.2 #307

wants to merge 128 commits into from

Conversation

@vorot93
Copy link
Contributor

vorot93 commented Aug 16, 2019

Quickly sew this together to get started with Tokio 0.2 runtime. Due to an additional trait bound in http-service I cut Zstd support. Also I removed App::run, although I don't think it will really be missed since async main has become commonplace.

Tested locally, appears to be working.

prasannavl and others added 30 commits May 13, 2019
fix cargo fmt

loosen up clippy to warnings on examples

snipe dev deps from core

eliminate some clippy warnings for examples

add publish false, and remove publish requirements

rename tide-examples to just examples
Precursor: Tide core isolation revamp
Fix example link in readme
Rename `serve` to `run`, add asynchronous `serve`
Co-Authored-By: Wonwoo Choi <chwo9843@gmail.com>
Check example in readme compiles during testing
Remove #[allow(unused_mut)]
Middleware-based compression and decompression
Improve curl command consistency
* Move core traits and types to tide-core

* Move cookies middleware to tide-cookies

* Remove unncessary dependencies and use relative paths in README
* Update travis config

 * Separate out individual build jobs for faster wall-clock testing

 * Fix clippy not actually denying warnings (excluded examples because
   these are currently failing and have non-trivial fixes)

 * Add build job that checks --no-default-features works

 * Add build job that checks for intra-doc-resolution failures (excluded
   tide because of bugs in re-exports with the intra-doc feature)

* Fix warnings

* Fix doc-link in tide-cookies
as follows #187
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
rustfmt
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Nemo157 and others added 9 commits Aug 21, 2019
Fix tide-slog docs.rs metadata
Artem Vorotnikov
…-21, remove async_await feature flag everywhere (#309)
…n header
CORS middleware: better handling of Origin
Copy link
Member

yoshuawuyts left a comment

Overall this looks good, but I think we can probably change out the git deps now that a new http-service has been published!

http-service = "0.3.1"
http-service-hyper = { version = "0.3.1", optional = true }
http-service = { git = "https://github.com/rustasync/http-service", branch = "tokio-0.2" }
http-service-hyper = { git = "https://github.com/rustasync/http-service", branch = "tokio-0.2", optional = true }

This comment has been minimized.

Copy link
@yoshuawuyts

yoshuawuyts Sep 2, 2019

Member

Is this still needed? I believe we already published updated versions right?

This comment has been minimized.

Copy link
@vorot93

vorot93 Sep 2, 2019

Author Contributor

If you look closely, this actually depends on the branch. Specifically, this one:

http-rs/http-service#43

Besides, that branch depends upon git hyper anyway.

This comment has been minimized.

Copy link
@secretfader

secretfader Sep 3, 2019

Contributor

0.3.1 was supposed to release earlier, but I only got it done today after seeing http-rs/http-service#45

Is there a reason we aren't using overrides for the Git dependencies in this branch? (Seems that would prevent issues with publishing, but correct me if I'm wrong.)

This comment has been minimized.

Copy link
@yoshuawuyts

yoshuawuyts Sep 5, 2019

Member

Not sure -- Git deps can't be published to crates.io either way.

Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version.
- [Release notes](https://github.com/sebasmagri/env_logger/releases)
- [Changelog](https://github.com/sebasmagri/env_logger/blob/master/CHANGELOG.md)
- [Commits](sebasmagri/env_logger@v0.6.1...v0.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@abonander

This comment has been minimized.

Copy link

abonander commented Sep 25, 2019

What's the status on this? I wanted to see if my refactor on master of multipart-async was suitable for solving #89 yet but I built it against futures-*-preview 0.3.0-alpha.18 and I don't really want to downgrade (although I can if necessary).

dependabot-preview bot and others added 5 commits Sep 30, 2019
Updates the requirements on [juniper](https://github.com/graphql-rust/juniper) to permit the latest version.
- [Release notes](https://github.com/graphql-rust/juniper/releases)
- [Commits](graphql-rust/juniper@juniper-0.13.1...juniper-v0.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Artem Vorotnikov
Artem Vorotnikov
Artem Vorotnikov
Artem Vorotnikov
@secretfader

This comment has been minimized.

Copy link
Contributor

secretfader commented Oct 29, 2019

I removed the example that required runtime in dfbaf72 a few moments ago, which should make wrapping up this PR a little bit easier. Feel free to rebase against master at your discretion @vorot93.

If you need help, I'm now available to help push this over the finish line.

@yoshuawuyts yoshuawuyts force-pushed the http-rs:master branch from dfbaf72 to 4a53890 Oct 30, 2019
@vorot93

This comment has been minimized.

Copy link
Contributor Author

vorot93 commented Oct 31, 2019

@secretfader It looks like the whole repository has been ripped inside out. This PR should be redone from scratch now. Even then I'm not sure that things won't break again in the process.

@yoshuawuyts

This comment has been minimized.

Copy link
Member

yoshuawuyts commented Oct 31, 2019

@vorot93 hi! I'm currently working on rebasing past commits based on a single repo; this may take a few days. Thanks so much for the work you've done, and apologies for the inconvenience! -- I'm hoping we can take the work that was done here and land it again soonish!

@abonander

This comment has been minimized.

@tyranron

This comment has been minimized.

Copy link

tyranron commented Nov 12, 2019

@abonander @yoshuawuyts why? Would you be so kind to explain the situation?

@abonander

This comment has been minimized.

Copy link

abonander commented Nov 12, 2019

I'm only somewhat familiar with the circumstances. @yoshuawuyts can explain much better than I can.

@tyranron

This comment has been minimized.

Copy link

tyranron commented Nov 12, 2019

@abonander if so, why do you propose to close this PR referring only to a comment where author says he is banned? Is his work negligible or undesirable? From what I see in this PR it was sorta ongoing and OK, and then suddenly closed without any explanation 😕

@abonander

This comment has been minimized.

Copy link

abonander commented Nov 12, 2019

The tone of the author's comment in that thread implies they don't have access to the PR/repo to complete it and/or have no interest in finishing it. Giving any more detail means entering a discussion I have no desire to partake in. It was my comment they replied to so I felt obliged to acknowledge it.

@tyranron

This comment has been minimized.

Copy link

tyranron commented Nov 12, 2019

@abonander thanks for making this clear.

@yoshuawuyts

This comment has been minimized.

Copy link
Member

yoshuawuyts commented Nov 12, 2019

@tyranron the behavior of several individuals in withoutboats/romio#106 but also through other outlets (dms, forums, repos) has been disappointing and below the standards we expect for community participation. This has been the reason why they've lost the privilege of publicly engaging on repositories that are part of this organization.

Regarding upgrading to a modern runtime. That has already been implemented as part of #350, and I'll be kicking off the series of PRs required for a new release over the course of this week.

@tyranron

This comment has been minimized.

Copy link

tyranron commented Nov 12, 2019

@yoshuawuyts I've followed through the comments in withoutboats/romio#106 and in relevant Reddit posts, but clearly don't see any bad or disappointing behavior of @vorot93. I'm no one to judge your community standards, but the whole situation with banning contributors feels rather disappointing and even quite awkward.

Anyway, thanks for the clarification. And I'm finishing this offtopic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.