Skip to content

pause_after checked by key presence, not truthiness #166

@mnot

Description

@mnot

Problem

pause_after is detected by key presence rather than truthiness:

https://github.com/http-tests/cache-tests/blob/main/test-engine/client/test.mjs#L54

pauseAfter: 'pause_after' in requests[i]

A request with pause_after: false would still pause, because the key is present.

Impact

Latent. The shared templates (tests/lib/templates.mjs) only ever set pause_after: true, and no test overrides it to false. But the field's false value is currently a no-op trap: anyone who writes pause_after: false (e.g. to override a template that sets it true) would not get the behavior they asked for.

Suggested fix

pauseAfter: requests[i].pause_after === true

Filed from an AI-assisted (Claude Code) review of the test harness, reviewed by a human before filing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions