New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing :path #166

Closed
andreineculau opened this Issue Jul 8, 2013 · 6 comments

Comments

Projects
None yet
3 participants
@andreineculau

andreineculau commented Jul 8, 2013

:path, whose values specify [...] the request-target

from https://github.com/http2/http2-spec/blob/master/draft-ietf-httpbis-http2.xml#L1762-1763

The <spanx style="verb">:path</spanx> header field includes the path and query parts
.

The request-target was previously, in HTTP/1.1, referred to as Request-URI, and RFC3986 refers to path as a syntax component. This would make the HTTP/2.0 header :path equal to <path>?<query>.

If the above reasoning is correct, then wouldn't it be confusing to refer to path - would that be the request-target itself, or the path section of the request-target URI ?

Maybe a clearer alternative would be: :target ? or leave it as :path and add a :query header ?

@martinthomson

This comment has been minimized.

Member

martinthomson commented Jul 8, 2013

This is a good comment, and we can certainly take editorial feedback on what it means to map these things from RFC 3986 (and 2616') concepts.

As the names go, that's a change that will affect people implementing this. I'd recommend taking your concerns to ietf-http-wg@w3.org, which is the best (and only) place to discuss more substantial issues.

@martinthomson

This comment has been minimized.

Member

martinthomson commented Aug 5, 2013

I think that the section on requests needs to be updated completely.

We need to say the following things:

  • HTTP header semantics are unchanged.
  • HTTP headers are encoded in lowercase.
  • The mechanism for identifying the target URI (effective request URI) is completely changed. It no longer requires inference.
  • There are some headers that are prohibited, simply because they no longer make sense.
@jasnell

This comment has been minimized.

Contributor

jasnell commented Aug 5, 2013

HTTP header field names are encoded in lowercase... values encoding is currently unchanged (until we get to the discussion of type codecs)

@martinthomson

This comment has been minimized.

Member

martinthomson commented Aug 6, 2013

HTTP header field names are encoded in lowercase... values encoding is currently unchanged (until we get to the discussion of type codecs)

Of course, consider that omission just as a result of me being excessively tired.

@martinthomson

This comment has been minimized.

Member

martinthomson commented Aug 6, 2013

Let me know if the edits I've made are confusing in any way.

@andreineculau

This comment has been minimized.

andreineculau commented Aug 6, 2013

FWIW, this issue targets the :path header, despite the later comments.
The header's section is completely left as is in your commit, as it still reads:

The :path header field includes the path and query parts of the target URI

Thus, this issue is still valid, and very much open IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment