Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

END_STREAM flag on CONTINUATION #549

Closed
mnot opened this issue Jul 7, 2014 · 2 comments

Comments

@mnot
Copy link
Member

commented Jul 7, 2014

Several reviewers have commented that END_STREAM being on HEADERS / PUSH_PROMISE instead of the last CONTINUATION is a design decision.

@martinthomson

This comment has been minimized.

Copy link
Member

commented Jul 11, 2014

To articulate the reasons for the current design:

  1. END_STREAM has no place on PUSH_PROMISE, or continuations thereof.
  2. Placing END_STREAM on HEADERS ensures that there is no possibility for stupid errors where you have END_STREAM but not END_HEADERS.
  3. CONTINUATIONS are in most respects a way to create a single frame from many. Logically, they are part of the preceding HEADERS/PUSH_PROMISE. Adding some flags from the preceding frame but not others is conceptually muddy.

I don't recall any complaint from people actually implementing the protocol.

@mnot

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2014

No consensus to make a change.

@mnot mnot closed this Jul 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.