Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Engine cleanup #305

Merged
merged 4 commits into from Jul 8, 2019

Conversation

@balatbn
Copy link

commented Jul 8, 2019

Cleanup SSL Engine during connection close.

With JDK SSLContext, this is not required. With native ssl context(Ex: conscrypt), calling close() methods frees up native memory associated with each connection. Otherwise, system will leak memory for every connection.

@rossabaker
Copy link
Member

left a comment

We can do a patch with this as soon as today, but I think we need to be a little less aggressive on what we suppress.

@balatbn

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

This throws SSLException. Is it OK if I just handle SSLException here?

bsrini added some commits Jul 8, 2019

bsrini
@rossabaker
Copy link
Member

left a comment

👍 thanks!

@rossabaker rossabaker merged commit 4b80d4e into http4s:master Jul 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@balatbn balatbn deleted the balatbn:engine_clean branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.