Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL Engine cleanup #305

Merged
merged 4 commits into from Jul 8, 2019
Merged

SSL Engine cleanup #305

merged 4 commits into from Jul 8, 2019

Conversation

@balatbn
Copy link

@balatbn balatbn commented Jul 8, 2019

Cleanup SSL Engine during connection close.

With JDK SSLContext, this is not required. With native ssl context(Ex: conscrypt), calling close() methods frees up native memory associated with each connection. Otherwise, system will leak memory for every connection.

Copy link
Member

@rossabaker rossabaker left a comment

We can do a patch with this as soon as today, but I think we need to be a little less aggressive on what we suppress.

Loading

@balatbn
Copy link
Author

@balatbn balatbn commented Jul 8, 2019

This throws SSLException. Is it OK if I just handle SSLException here?

Loading

Copy link
Member

@rossabaker rossabaker left a comment

👍 thanks!

Loading

@rossabaker rossabaker merged commit 4b80d4e into http4s:master Jul 8, 2019
1 check passed
Loading
@balatbn balatbn deleted the engine_clean branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants