Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to http4s plugin #153

Merged
merged 11 commits into from
Mar 9, 2023
Merged

Migrate to http4s plugin #153

merged 11 commits into from
Mar 9, 2023

Conversation

danicheg
Copy link
Member

@danicheg danicheg commented Mar 8, 2023

Towards resolving #152

@danicheg danicheg requested a review from rossabaker March 8, 2023 08:22
@danicheg
Copy link
Member Author

danicheg commented Mar 9, 2023

Perhaps that may take time to wait for Ross, so maybe we can call for help from @armanbilge with reviewing this. The diff is impressive (but not for Arman, I know 😆), but these changes were auto-generated mostly.

armanbilge
armanbilge approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! Noticed a couple small things but should be fine!

build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
docs/index.md Outdated

```scala
libraryDependencies ++= Seq(
"org.http4s" %% "http4s-session" % "<version>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"org.http4s" %% "http4s-session" % "<version>"
"org.http4s" %% "http4s-session" % "@VERSION@"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's interesting but @VERSION@ uses a snapshot version. Do you know if we can bypass that behaviour?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I'm not sure that this microsite will be published, so whatever, let's move on

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's bizarre that I saw the snapshot version locally, but at https://http4s.github.io/http4s-session/ we are good!

danicheg and others added 3 commits March 9, 2023 19:31
@danicheg @armanbilge
Use Http4sOrgSitePlugin
273e50e 
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
@danicheg @armanbilge
Use @VERSION@ on the site page
b0a066c 
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
@danicheg
One more clean-up of build.sbt
956b3d7
@danicheg danicheg merged commit 5d7293a into http4s:main Mar 9, 2023
@danicheg danicheg deleted the migrate-to-http4s-plugin branch March 9, 2023 17:05
@rossabaker
Copy link
Member

Sorry, I'm in Day 3 (of 3) of laptops-closed meetings... thanks for moving this forward.

@danicheg
Copy link
Member Author

danicheg commented Mar 9, 2023

Yeah, kudos to Arman. It's great to have you with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

@rossabaker rossabaker Awaiting requested review from rossabaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danicheg @rossabaker @armanbilge