pathInfo calculation on servlet does not include contextPath length #140

Closed
rossabaker opened this Issue Dec 20, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@rossabaker
Member

rossabaker commented Dec 20, 2014

The pathInfoCaret needs to be set at the contextPath plus the servletContext. Right now, we're only accounting for the servletPath, which only works in the root context path.

@rossabaker rossabaker added the bug label Dec 20, 2014

@rossabaker rossabaker self-assigned this Dec 20, 2014

@rossabaker

This comment has been minimized.

Show comment
Hide comment
@rossabaker

rossabaker Dec 20, 2014

Member

Found and fixed this as part of #139. Could be backported to an 0.5.1, if anybody notices and complains.

Member

rossabaker commented Dec 20, 2014

Found and fixed this as part of #139. Could be backported to an 0.5.1, if anybody notices and complains.

@rossabaker rossabaker added this to the 0.6 milestone Dec 20, 2014

rossabaker added a commit that referenced this issue Dec 20, 2014

Syntax for easy mounting of services within a .war deployment.
Created an examples-war project, from which a simple `package` command
builds a portable war for servlet container deployments.  We didn't
want http4s-jetty or http4s-tomcat in this project, which caused a
split of the examples project.

As a result of this refactoring, it's now possible to conveniently start
and test any of the backends with a command like so:

   sbt examples-blaze/reStart shell

Or, for a container deployment:

   sbt examples-war/container:start shell

Closes #139, #140.

@rossabaker rossabaker closed this Dec 21, 2014

@rossabaker rossabaker modified the milestones: 0.5.1, 0.6 Dec 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment