Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http4sServlet doesn't drain the body if setting the response headers throws #1782

Closed
rossabaker opened this issue Apr 14, 2018 · 0 comments
Closed
Labels
bug

Comments

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 14, 2018

These methods can throw if the servlet response is committed. If we generate a response, we must drain the body even if we don't render it to run the response finalizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.