Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitraries should be given unique names #2070

Closed
rossabaker opened this issue Sep 12, 2018 · 1 comment
Closed

Arbitraries should be given unique names #2070

rossabaker opened this issue Sep 12, 2018 · 1 comment

Comments

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 12, 2018

It's important for implicit instances to have unique names. See implicit naming in the cats documentation. See cats' Arbitrary as an example of this. It would be nice if our arbitraries followed the same convention.

@pgabara
Copy link

@pgabara pgabara commented Oct 1, 2018

Hi @rossabaker, PR is open. Let me know what you think

@aeons aeons closed this in #2141 Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants